Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name debug helper containers more explicitly #4946

Merged

Conversation

briandealwis
Copy link
Member

Description
Cosmetic fix to improve names used for skaffold debug support images. Previously images would be names install-xxx-support, but it's not clear these images were installing debug support tools.

Before:

Press Ctrl+C to exit
Not watching for changes...
[install-go-support] Installing runtime debugging support files in /dbg
[install-go-support] Installation complete

After:

Press Ctrl+C to exit
Not watching for changes...
[install-go-debug-support] Installing runtime debugging support files in /dbg
[install-go-debug-support] Installation complete

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #4946 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4946   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files         360      360           
  Lines       12527    12527           
=======================================
  Hits         9065     9065           
  Misses       2800     2800           
  Partials      662      662           
Impacted Files Coverage Δ
pkg/skaffold/debug/transform.go 89.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3f204...4b0d985. Read the comment docs.

@tejal29 tejal29 merged commit d18160c into GoogleContainerTools:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants